Properly ref and deref old pbufs in 3c90x.c.

[netwatch.git] / net / 3c90x.c

diff --git a/net/3c90x.c b/net/3c90x.c
index 64dd65549d96ca977e8cead947278cf713a7f4c9..a1b319c6ffd723f12c50f1f85e66521441de8e4b 100644 (file)
--- a/net/3c90x.c
+++ b/net/3c90x.c
@@ -224,8 +224,10 @@ typedef struct
     {
     unsigned int       DnNextPtr;
     unsigned int       FrameStartHeader;
-    unsigned int       DataAddr;
-    unsigned int       DataLength;
+    struct {
+      unsigned int addr;
+      unsigned int len;
+    } __attribute ((aligned(8))) segments[64];
     }
     TXD __attribute__ ((aligned(8))); /* 64-bit aligned for bus mastering */
 
@@ -473,17 +475,16 @@ static void a3c90x_reset(void)
  *** pkt - the pointer to the packet data itself.
  ***/
 static void
-a3c90x_transmit(unsigned int size, const char *pkt)
+a3c90x_transmit(struct pbuf *p)
 {
        unsigned char status;
-       static unsigned int stillwaiting = 0;
-
-       if (stillwaiting)
+       static struct pbuf *oldpbuf = NULL;
+       unsigned int n, len;
+       
+       if (oldpbuf)
        {
-               outputf("Waiting for network completion...");
                while (!(inw(INF_3C90X.IOAddr + regCommandIntStatus_w) & INT_TXCOMPLETE) && oneshot_running())
                        ;
-               outputf("Done");
                if (!(inw(INF_3C90X.IOAddr + regCommandIntStatus_w) & INT_TXCOMPLETE))
                {
                        outputf("3c90x: tx timeout? txstat %02x", inb(INF_3C90X.IOAddr + regTxStatus_b));
@@ -491,18 +492,30 @@ a3c90x_transmit(unsigned int size, const char *pkt)
                }
                status = inb(INF_3C90X.IOAddr + regTxStatus_b);
                outb(INF_3C90X.IOAddr + regTxStatus_b, 0x00);
-               stillwaiting = 0;
+               pbuf_free(oldpbuf);
+               oldpbuf = NULL;
        }
 
        _issue_command(INF_3C90X.IOAddr, cmdStallCtl, 2 /* Stall download */);
 
        /** Setup the DPD (download descriptor) **/
        INF_3C90X.TransmitDPD.DnNextPtr = 0;
+       len = 0;
+       n = 0;
+       oldpbuf = p;
+       for (; p; p = p->next)
+       {
+               INF_3C90X.TransmitDPD.segments[n].addr = v2p(p->payload);
+               INF_3C90X.TransmitDPD.segments[n].len = p->len | (p->next ? 0 : (1 << 31));
+               len += p->len;
+               pbuf_ref(p);
+               n++;
+       }
        /** set notification for transmission completion (bit 15) **/
-       INF_3C90X.TransmitDPD.FrameStartHeader = (size) | 0x8000;
-       INF_3C90X.TransmitDPD.DataAddr = v2p((void*)pkt);
-       INF_3C90X.TransmitDPD.DataLength = size + (1<<31);
+       INF_3C90X.TransmitDPD.FrameStartHeader = (len) | 0x8000;
        
+       outputf("3c90x: Sending %d byte %d seg packet", len, n);
+
        /** Send the packet **/
        outl(INF_3C90X.IOAddr + regDnListPtr_l, v2p(&(INF_3C90X.TransmitDPD)));
        _issue_command(INF_3C90X.IOAddr, cmdStallCtl, 3 /* Unstall download */);
@@ -516,9 +529,6 @@ a3c90x_transmit(unsigned int size, const char *pkt)
                return;
        }
 
-       oneshot_start_ms(10);
-       stillwaiting = 1;
-               
 #if 0          
        /** successful completion (sans "interrupt Requested" bit) **/
        if ((status & 0xbf) == 0x80)